Fix timezone fallback to CoreExtension in IntlExtension#3903
Merged
fabpot merged 1 commit intotwigphp:3.xfrom Nov 21, 2023
Merged
Fix timezone fallback to CoreExtension in IntlExtension#3903fabpot merged 1 commit intotwigphp:3.xfrom
fabpot merged 1 commit intotwigphp:3.xfrom
Conversation
This is probably a regression from twigphp#3844
Contributor
|
Thank you @keulinho. |
|
This PR breaks the behavior of
The exception thrown if the above feature is used: |
Contributor
fabpot
added a commit
that referenced
this pull request
Apr 3, 2024
This PR was squashed before being merged into the 3.x branch.
Discussion
----------
Fix exception when timezone is false
When passing `false` in the timezone param, twig returns an exception:
> An exception has been thrown during the rendering of a template ("Twig\Extra\Intl\IntlExtension::createDateFormatter(): Argument 5 ($timezone) must be of type ?DateTimeZone, bool given
Passing `false` is supported and allows to skip the timezone conversion.
Regression introduced by #3903
Commits
-------
7e8f5eb Fix exception when timezone is false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably a regression from #3844
Refer to my comment on the original MR: #3844 (comment)