Variational autoencoder for tract profile data #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@SamChou05 : now that #19 is merged, please go ahead and merge the main branch into your branch or rebase on top of main so that we can see whether your tests will pass. |
arokem
reviewed
Mar 18, 2025
arokem
reviewed
Mar 18, 2025
arokem
reviewed
Mar 18, 2025
arokem
reviewed
Mar 18, 2025
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Member
|
The code in pt_models looks great! I wonder whether |
Collaborator
Author
|
I agree with your comment with prep_first_tract_data, prep_fa_dataset, and prep_fa_flattned_data, so I moved them to my repository containing the experiments and removed them from this PR. |
Member
|
Great! You'll need to move out the related test as well |
Member
|
Could you please add docstrings to all the new functions/classes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.