Skip to content

Conversation

@santi-h
Copy link

@santi-h santi-h commented Aug 21, 2017

Opens the file at the selected line number if any specified. For example, something like app/models/rental_vehicle.rb:20 would open the file app/models/rental_vehicle.rb and automatically select line number 20

@santi-h santi-h force-pushed the open-on-line-number branch from 09c96f2 to 280a8a5 Compare June 11, 2019 05:28
@santi-h santi-h force-pushed the open-on-line-number branch from 280a8a5 to 581363f Compare June 11, 2019 05:39
@iamntz
Copy link
Collaborator

iamntz commented Jun 11, 2019

The point of this package is to quickly open included files. I'm not very familiar with ruby, but you can write code similar to

require `rental_vehicle.rb:20`

?

If not, then even the functionality is nice, I think it's very ... uhm... edgy.

@santi-h
Copy link
Author

santi-h commented Jun 11, 2019

but you can write code similar to

@iamntz not really. I use sublime to look at and manipulate logs. These logs usually contain paths to specific lines in the code. Something like this comes in very handy in those cases.

@iamntz iamntz requested a review from titoBouzout June 11, 2019 15:24
@iamntz
Copy link
Collaborator

iamntz commented Jun 11, 2019

Actually this make sense. Thanks for clarifiying.

@titoBouzout
Copy link
Owner

Hi there! Some time ago I accepted some pull request that broke my local installation and I didnt have any time to see what's wrong with it. I had to revert to make it behave like it was behaving (I dont even remember what's broken) I was thinking maybe we should rewrite it. We have a good idea of what it should do which is not really the way its been implemented as the use cases started appearing after it was wrote, so it looks kinda hacky.

@santi-h
Copy link
Author

santi-h commented Jun 11, 2019

@titoBouzout sounds good. You know this code better than I do so I could use some pointers.
If you'd like to take a stab at it yourself I can close this PR too. Either way works for me, let me know.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants