Skip to content

Conversation

@lyakh
Copy link
Collaborator

@lyakh lyakh commented Apr 22, 2025

audio_stream_recalc_align() is called from micsel, which can be build as a module, export it.

audio_stream_recalc_align() is called from micsel, which can be build
as a module, export it.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@serhiy-katsyuba-intel
Copy link
Contributor

@wszypelt , could you check if this PR is enough to fix the MicSel crash (recent PTL regression)? If yes, we can abandon #9971 and prefer this PR as a fix.

@wszypelt
Copy link

@serhiy-katsyuba-intel @lyakh Sure, I'll start Full Scope for this PR, if everything goes well I should have the results tomorrow

@lyakh
Copy link
Collaborator Author

lyakh commented Apr 23, 2025

@serhiy-katsyuba-intel @lyakh Sure, I'll start Full Scope for this PR, if everything goes well I should have the results tomorrow

@wszypelt actually a simple test would be enough - it's quite deterministic - either all the required symbols are there, or some are missing

@wszypelt
Copy link

wszypelt commented Apr 23, 2025

@lyakh @serhiy-katsyuba-intel After analyzing the FullScope results, MICSEL is working properly, good to merge :)

@lyakh
Copy link
Collaborator Author

lyakh commented Apr 24, 2025

@serhiy-katsyuba-intel could you review and - if acceptable - approve this?

@kv2019i kv2019i merged commit 150c9ff into thesofproject:main Apr 24, 2025
44 of 49 checks passed
@lyakh lyakh deleted the micsel branch April 28, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants