ptl: Make MicSel a built-in module, not an llext module #9971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicSel crashes when built as an llext module. Temporarily make it a built-in until the problem is resolved. When built as an llext module, MicSel crashes when attempting to call audio_stream_recalc_align(). The address of audio_stream_recalc_align() is printed as NULL. Backtrace: set_selector_params() --> audio_stream_set_channels() --> audio_stream_recalc_align(). Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
Author
|
This is to fix the regression introduced with this PR #9957. |
wszypelt
approved these changes
Apr 18, 2025
abonislawski
approved these changes
Apr 22, 2025
Collaborator
|
@serhiy-katsyuba-intel how about #9975 instead? Does it also fix the issue or do more functions need to be exported? |
Collaborator
|
adding "DNM" until #9975 is clarified |
Contributor
Author
|
Abandoning this if favor of #9975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MicSel crashes when built as an llext module. Temporarily make it a built-in until the problem is resolved.
When built as an llext module, MicSel crashes when attempting to call audio_stream_recalc_align(). The address of audio_stream_recalc_align() is printed as NULL.
Backtrace: set_selector_params() --> audio_stream_set_channels() -->
audio_stream_recalc_align().