Skip to content

waves: avoid calling MaxxEffect_Message before MaxxEffect_Initialize #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Mar 11, 2025
Merged

waves: avoid calling MaxxEffect_Message before MaxxEffect_Initialize #9882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/audio/module_adapter/module/waves/waves.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ struct waves_codec_data {
void *response;
uint32_t config_blob_size;
void *config_blob;
bool initialized;
};

enum waves_codec_params {
Expand Down Expand Up @@ -353,6 +354,7 @@ static int waves_effect_init(struct processing_module *mod)
comp_err(dev, "waves_effect_init() MaxxEffect_Initialize returned %d", status);
return -EINVAL;
}
waves_codec->initialized = true;

comp_dbg(dev, "waves_effect_init() done");
return 0;
Expand Down Expand Up @@ -509,14 +511,17 @@ static int waves_effect_message(struct processing_module *mod, void *data, uint3
MaxxStatus_t status;
uint32_t response_size = 0;

comp_info(dev, "waves_effect_message() start data %p size %d", data, size);
if (waves_codec->initialized) {
comp_info(dev, "waves_effect_message() start data %p size %d", data, size);

status = MaxxEffect_Message(waves_codec->effect, data, size,
waves_codec->response, &response_size);
status = MaxxEffect_Message(waves_codec->effect, data, size,
waves_codec->response, &response_size);

if (status) {
comp_err(dev, "waves_effect_message() MaxxEffect_Message returned %d", status);
return -EINVAL;
if (status) {
comp_err(dev, "waves_effect_message() MaxxEffect_Message returned %d",
status);
return -EINVAL;
}
}

#if CONFIG_TRACEV
Expand Down Expand Up @@ -693,6 +698,7 @@ static int waves_codec_init(struct processing_module *mod)
return -ENOMEM;
}
waves_codec->response = response;
waves_codec->initialized = false;

comp_dbg(dev, "waves_codec_init() done");
return ret;
Expand Down Expand Up @@ -844,6 +850,7 @@ static int waves_codec_reset(struct processing_module *mod)
if (codec->mpd.out_buff)
module_free_memory(mod, codec->mpd.out_buff);

waves_codec->initialized = false;
comp_dbg(dev, "waves_codec_reset() done");
return ret;
}
Expand Down
Loading