Skip to content

waves: avoid calling MaxxEffect_Message before MaxxEffect_Initialize #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgirdwood merged 1 commit into from
Mar 11, 2025
Merged

waves: avoid calling MaxxEffect_Message before MaxxEffect_Initialize #9882

lgirdwood merged 1 commit into from
Mar 11, 2025

Conversation

@barry-waves
Copy link
Contributor

@barry-waves barry-waves commented Mar 10, 2025 

Save the blob into the cache and ensure that MaxxEffect_Message
is not called before MaxxEffect_Initialize to avoid returning
an error code from MaxxEffect_Message.

@barry-waves barry-waves requested a review from johnylin76 March 10, 2025 11:51
johnylin76
johnylin76 reviewed Mar 10, 2025
View reviewed changes
@barry-waves
waves: avoid calling MaxxEffect_Message before MaxxEffect_Initialize
c131ebb 
    Save the blob into the cache and ensure that MaxxEffect_Message
    is not called before MaxxEffect_Initialize to avoid returning
    an error code from MaxxEffect_Message.

Signed-off-by: barry.jan <barry.jan@waves.com>
@johnylin76
Copy link
Contributor

johnylin76 commented Mar 11, 2025

LGTM.
BTW, I am curious of the hazard before the fix. Could this bug bring about DSP error?
It is a common case that set_configuration() may be called before prepare(). I am sure we have been done that way to Waves in previous projects, but we didn't feel something wrong.

@lgirdwood lgirdwood merged commit 90b7f55 into thesofproject:main Mar 11, 2025
44 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes

@johnylin76 johnylin76 johnylin76 approved these changes

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@barry-waves @johnylin76 @lgirdwood