[SKIP SOF-TEST] .github: really disable spar-se instead of breaking it #10424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes commit 56649f6 ("github: workflows: disable sparse checks temporarily") which caused a syntax error GitHub jobs can be disabled one by one but not all at once: https://docs.github.com/en/actions/reference/workflows-and-actions/ workflow-syntax#jobsjob_idif This syntax error was found by Copilot; quoting: thesofproject#10337 (comment) > The if: false statement is incorrectly placed at the file level > between jobs: and the job definition. This will cause a syntax > error. It should be placed within a specific job definition. Move this > line and the preceding comments to be indented under the job > name (e.g., after the job key on the next line This has blocked daily tests from running for ages: https://github.com/thesofproject/sof/actions/runs/20048113632 ``` Invalid workflow file: .github/workflows/daily-tests.yml#L42 error parsing called workflow ".github/workflows/daily-tests.yml" -> "./.github/workflows/sparse-zephyr.yml" (source branch with sha:e00764e7fbe3315c0d8e1fa87624aec4e37db7e3) : (Line: 17, Col: 7): Unexpected value 'false' ``` Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
changed the title
Collaborator
Author
|
Syntax error is gone: 
(Added [SKIP SOFCI] but too late, sorry) |
marc-hb
changed the title
tmleman
approved these changes
Dec 10, 2025
Collaborator
Author
Nobody does but they are still very useful when GitHub or something upgrades a container or similar and some obscure regression or incompatibility sneaks in. Then, Pull Requests start failing mysteriously and everyone is scratching their head - until they look at daily test results that immediately pinpoint the regression. That's the main purpose. There's also a red/green badge on the project front page: https://github.com/thesofproject/sof |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes commit 56649f6 ("github: workflows: disable sparse checks temporarily") which caused a syntax error
GitHub jobs can be disabled one by one but not all at once: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idif
This syntax error was found by Copilot; quoting the original PR:
This has blocked daily tests from running for ages:
https://github.com/thesofproject/sof/actions/runs/20048113632