Skip to content

Commit 2bf8638

Browse files
marc-hbkv2019i
authored andcommitted
.github: really disable spar-se instead of breaking it
Fixes commit 56649f6 ("github: workflows: disable sparse checks temporarily") which caused a syntax error GitHub jobs can be disabled one by one but not all at once: https://docs.github.com/en/actions/reference/workflows-and-actions/ workflow-syntax#jobsjob_idif This syntax error was found by Copilot; quoting: #10337 (comment) > The if: false statement is incorrectly placed at the file level > between jobs: and the job definition. This will cause a syntax > error. It should be placed within a specific job definition. Move this > line and the preceding comments to be indented under the job > name (e.g., after the job key on the next line This has blocked daily tests from running for ages: https://github.com/thesofproject/sof/actions/runs/20048113632 ``` Invalid workflow file: .github/workflows/daily-tests.yml#L42 error parsing called workflow ".github/workflows/daily-tests.yml" -> "./.github/workflows/sparse-zephyr.yml" (source branch with sha:e00764e7fbe3315c0d8e1fa87624aec4e37db7e3) : (Line: 17, Col: 7): Unexpected value 'false' ``` Signed-off-by: Marc Herbert <marc.herbert@intel.com>
1 parent e00764e commit 2bf8638

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.github/workflows/sparse-zephyr.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,15 @@ defaults:
1212
shell: bash
1313

1414
jobs:
15-
# disable until https://github.com/zephyrproject-rtos/zephyr/issues/93444
16-
# is fixed
17-
if: false
18-
1915
# As of sparse commit ce1a6720f69e / Sept 2022, the exit status of
2016
# sparse.c is an unusable mess and always zero in practice. Moreover
2117
# SOF has hundreds of sparse warnings right now. So fail only on a
2218
# small subset of specific warnings defined in
2319
# sof/scripts/parse_sparse_output.sh
2420
warnings-subset:
21+
# disable until https://github.com/zephyrproject-rtos/zephyr/issues/93444
22+
# is fixed
23+
if: false
2524

2625
# We're sharing the sparse binary with the zephyr-build container so keep
2726
# this in sync with it.

0 commit comments

Comments
 (0)