Skip to content

Conversation

@redzynix
Copy link
Contributor

@redzynix redzynix commented Sep 30, 2025

zephyr-lite dockerimage

Update base to zephyr-build v0.28.4 and add improvements to the dockerimage

  • Remove python3.12 installation as it's already supplied by new
    docker base
  • Remove sysroots from toolchains to free up space
  • Install jsonschema and cmake
  • Update SDK to 0.17.4
  • Use venv for python packages

Zephyr workflows rework

Drop support of docker-run.sh wrapper used in zephyr workflows in favor of using container: image: tag that is built into github workflow syntax
Reworked workflows include:

Signed-off-by: Mateusz Redzynia mateuszx.redzynia@intel.com

@redzynix redzynix added the DNM Do Not Merge tag label Sep 30, 2025
@redzynix redzynix force-pushed the update-zephyr-lite-to-v0.28.4 branch 9 times, most recently from d76dba4 to 61a03f5 Compare October 1, 2025 13:12
@redzynix redzynix changed the title [SKIP SOF-CI TEST][DNM]DO NOT REVIEW] zephyr-lite: update base to zephyr-build v0.28.4 [SKIP SOF-CI TEST][DNM]DO NOT REVIEW] zephyr-lite: update base to zephyr-build v0.28.4 and rework zephyr workflows Oct 1, 2025
@redzynix redzynix force-pushed the update-zephyr-lite-to-v0.28.4 branch from 1b524d3 to b6de80a Compare October 1, 2025 13:59
@redzynix redzynix changed the title [SKIP SOF-CI TEST][DNM]DO NOT REVIEW] zephyr-lite: update base to zephyr-build v0.28.4 and rework zephyr workflows zephyr-lite: update base to zephyr-build v0.28.4 and rework zephyr workflows Oct 1, 2025
@redzynix redzynix removed the DNM Do Not Merge tag label Oct 1, 2025
@redzynix redzynix marked this pull request as ready for review October 1, 2025 14:00
@redzynix redzynix requested a review from dbaluta as a code owner October 1, 2025 14:00
Copilot AI review requested due to automatic review settings October 1, 2025 14:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Update zephyr-lite to zephyr-build v0.28.4, streamline the image and CI by leveraging GitHub Actions’ container: image: support, and bump the Zephyr SDK to 0.17.4 with a Python venv for tooling.

  • Upgrade base image and SDK (v0.28.4 / 0.17.4) and trim unused toolchains
  • Move CI to container-based workflows; drop docker-run.sh wrapper usage
  • Install cmake and jsonschema in a venv and simplify docker-build.sh

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
zephyr/docker-run.sh Update image tag and comments to v0.28.4/SDK 0.17.4 to reflect new base.
zephyr/docker-build.sh Remove redundant pip-based cmake install now provided by the image venv.
scripts/docker_build/zephyr_lite/Dockerfile Switch to zephyr-build v0.28.4, prune toolchains/sysroots, add venv packages, set env, and default shell.
.github/workflows/zephyr.yml Rework to use container image, simplify west steps/paths, and adjust build/run locations.
.github/workflows/sparse-zephyr.yml Use container image, streamline west usage and paths, and keep sparse build inside container.
.github/workflows/llext.yml Use container image, simplify west usage, and run builds directly without wrapper.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Update base to zephyr-build v0.28.4 and:
- Remove python3.12 installation as it's already supplied by new
docker base
- Remove sysroots from toolchains to free up space
- Install jsonschema, cmake
- Update SDK to 0.17.4
- Use python venv for packages

Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
Update zephyr-lite to v0.28.4 version with sdk 0.17.4 and jsonschema
installed.

Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
Cmake is now shipped with zephyr-lite dockerimage, there is no need to
install it again.

Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
Drop usage of docker-run.sh in favor of using
runs-on: container: image: which is the correct approach for github
workflows.

Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
@redzynix redzynix force-pushed the update-zephyr-lite-to-v0.28.4 branch from b6de80a to 492ded2 Compare October 1, 2025 14:11
Copy link
Contributor

@tmleman tmleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow testing the build on Windows is using an older SDK. Can we update it as part of this PR?
https://github.com/thesofproject/sof/blob/main/.github/workflows/zephyr.yml#L286-L306

Drop usage of docker-run.sh in favor of using
runs-on: container: image: which is the correct approach for github
workflows.

Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
Drop usage of docker-run.sh in favor of using
runs-on: container: image: which is the correct approach for github
workflows.

Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
@redzynix redzynix force-pushed the update-zephyr-lite-to-v0.28.4 branch from 492ded2 to b69ef6e Compare October 2, 2025 08:52
@redzynix
Copy link
Contributor Author

redzynix commented Oct 2, 2025

The workflow testing the build on Windows is using an older SDK. Can we update it as part of this PR? main/.github/workflows/zephyr.yml#L286-L306

Updated windows zephyr sdk to 0.17.4

Copy link
Member

@abonislawski abonislawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redzynix Not blocking as we haven't been 100% systematic with the prefixes, but for future PRs, use "github: llext: change workflot to foobar" prefix for git commits that touch the github workflows. See "git log .github/" for example of past changes.

E.g. prefix "zephyr: ..." indicates you are changing the zephyr SOF implementation that lives in work/sof/zephyr, but that's not really the case in this PR.

@kv2019i kv2019i merged commit e962549 into thesofproject:main Oct 2, 2025
33 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] CI Failing: Update Docker Image to Include Missing jsonschema Dependency

8 participants