-
Notifications
You must be signed in to change notification settings - Fork 349
zephyr-lite: update base to zephyr-build v0.28.4 and rework zephyr workflows #10273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zephyr-lite: update base to zephyr-build v0.28.4 and rework zephyr workflows #10273
Conversation
d76dba4 to
61a03f5
Compare
1b524d3 to
b6de80a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Update zephyr-lite to zephyr-build v0.28.4, streamline the image and CI by leveraging GitHub Actions’ container: image: support, and bump the Zephyr SDK to 0.17.4 with a Python venv for tooling.
- Upgrade base image and SDK (v0.28.4 / 0.17.4) and trim unused toolchains
- Move CI to container-based workflows; drop docker-run.sh wrapper usage
- Install cmake and jsonschema in a venv and simplify docker-build.sh
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| zephyr/docker-run.sh | Update image tag and comments to v0.28.4/SDK 0.17.4 to reflect new base. |
| zephyr/docker-build.sh | Remove redundant pip-based cmake install now provided by the image venv. |
| scripts/docker_build/zephyr_lite/Dockerfile | Switch to zephyr-build v0.28.4, prune toolchains/sysroots, add venv packages, set env, and default shell. |
| .github/workflows/zephyr.yml | Rework to use container image, simplify west steps/paths, and adjust build/run locations. |
| .github/workflows/sparse-zephyr.yml | Use container image, streamline west usage and paths, and keep sparse build inside container. |
| .github/workflows/llext.yml | Use container image, simplify west usage, and run builds directly without wrapper. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Update base to zephyr-build v0.28.4 and: - Remove python3.12 installation as it's already supplied by new docker base - Remove sysroots from toolchains to free up space - Install jsonschema, cmake - Update SDK to 0.17.4 - Use python venv for packages Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
Update zephyr-lite to v0.28.4 version with sdk 0.17.4 and jsonschema installed. Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
Cmake is now shipped with zephyr-lite dockerimage, there is no need to install it again. Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
Drop usage of docker-run.sh in favor of using runs-on: container: image: which is the correct approach for github workflows. Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
b6de80a to
492ded2
Compare
tmleman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow testing the build on Windows is using an older SDK. Can we update it as part of this PR?
https://github.com/thesofproject/sof/blob/main/.github/workflows/zephyr.yml#L286-L306
Drop usage of docker-run.sh in favor of using runs-on: container: image: which is the correct approach for github workflows. Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
Drop usage of docker-run.sh in favor of using runs-on: container: image: which is the correct approach for github workflows. Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
492ded2 to
b69ef6e
Compare
Updated windows zephyr sdk to 0.17.4 |
abonislawski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@redzynix Not blocking as we haven't been 100% systematic with the prefixes, but for future PRs, use "github: llext: change workflot to foobar" prefix for git commits that touch the github workflows. See "git log .github/" for example of past changes.
E.g. prefix "zephyr: ..." indicates you are changing the zephyr SOF implementation that lives in work/sof/zephyr, but that's not really the case in this PR.
zephyr-lite dockerimage
Update base to zephyr-build v0.28.4 and add improvements to the dockerimage
docker base
Zephyr workflows rework
Drop support of docker-run.sh wrapper used in zephyr workflows in favor of using
container: image:tag that is built into github workflow syntaxReworked workflows include:
Signed-off-by: Mateusz Redzynia mateuszx.redzynia@intel.com