xtos: cleanup Kconfig.xtos, remove CONFIG_DMA_GW and other unused options #10215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the XTOS code was removed in commit b8266ae ("build: delete more XTOS-only files"). SOF still maintains support to use old XTOS drivers in Zephyr builds. There are multiple DMA and IPC drivers in the tree used like this. Move definitions required by these XTOS drivers to a separate Kconfig.xtos tree. This allows to clean up the top-level Kconfig.sof. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Remove unused Kconfig options from Kconfig.sof. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR moves XTOS-related build configuration options from the main Kconfig.sof file to a separate Kconfig.xtos file to improve organization and clean up the top-level configuration. The PR also removes some unused configuration options (MEM_WND and INTEL_IOMUX) from the original file.
Key changes:
- Created a new Kconfig.xtos file containing XTOS and DMA-related configuration options
- Removed XTOS configuration options from Kconfig.sof and added a reference to include the new file
- Eliminated unused MEM_WND and INTEL_IOMUX configuration options
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Kconfig.xtos | New file containing XTOS and DMA configuration options moved from Kconfig.sof |
| Kconfig.sof | Cleaned up by removing XTOS options and unused configs, added reference to new Kconfig.xtos |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Remote this altenrative DMA client code implementation used on Intel platforms and XTOS. This has not in-tree users anymore, so this is unused and can be removed. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
akloniex,
bardliao,
marcinszkudlinski and
pblaszko
as code owners
kv2019i
changed the title
Collaborator
Author
|
V2:
|
tmleman
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and remove unused options. Intent is to clean the top-level Kconfig.sof