Skip to content

Audio: KPB, Mixin-Mixout: Fix missing HiFi3 header include #10178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Aug 25, 2025
Merged

Audio: KPB, Mixin-Mixout: Fix missing HiFi3 header include #10178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/audio/kpb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@
#include <sof/lib/notifier.h>
#endif

#ifdef KPB_HIFI3
#include <xtensa/tie/xt_hifi3.h>
#endif

static const struct comp_driver comp_kpb;

LOG_MODULE_REGISTER(kpb, CONFIG_SOF_LOG_LEVEL);
Expand Down
2 changes: 2 additions & 0 deletions src/audio/mixin_mixout/mixin_mixout_hifi3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

#if SOF_USE_HIFI(3, MIXIN_MIXOUT) || SOF_USE_HIFI(4, MIXIN_MIXOUT)

Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header include should be conditional like in kpb.c to maintain consistency and avoid unnecessary includes when HiFi3 is not being used. Consider wrapping it with appropriate preprocessor conditions.

Suggested change

Copilot uses AI. Check for mistakes.
#include <xtensa/tie/xt_hifi3.h>

#if CONFIG_FORMAT_S16LE
static void mix_s16(struct cir_buf_ptr *sink, int32_t start_sample, int32_t mixed_samples,
const struct cir_buf_ptr *source,
Expand Down
Loading