Audio: KPB, Mixin-Mixout: Fix missing HiFi3 header include #10178
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If build format.h as generic without intrinsics, these modules fail to build due to no header included for HiFi3. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build issue where HiFi3-specific modules fail to compile when format.h is built without intrinsics support. The fix adds the necessary HiFi3 header includes to ensure proper compilation.
- Adds missing
xtensa/tie/xt_hifi3.hheader include to mixin_mixout HiFi3 implementation - Adds conditional HiFi3 header include to KPB module when
KPB_HIFI3is defined
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/audio/mixin_mixout/mixin_mixout_hifi3.c | Adds unconditional HiFi3 header include for intrinsics support |
| src/audio/kpb.c | Adds conditional HiFi3 header include when KPB_HIFI3 is defined |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| #include "mixin_mixout.h" | ||
|
|
||
| #if SOF_USE_HIFI(3, MIXIN_MIXOUT) || SOF_USE_HIFI(4, MIXIN_MIXOUT) | ||
|
|
There was a problem hiding this comment.
The header include should be conditional like in kpb.c to maintain consistency and avoid unnecessary includes when HiFi3 is not being used. Consider wrapping it with appropriate preprocessor conditions.
Suggested change
lyakh
approved these changes
Aug 21, 2025
lgirdwood
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If build format.h as generic without intrinsics, these modules fail to build due to no header included for HiFi3.