Skip to content

ipc: do not hold a spinlock when calling schedule_ipc_worker() #10170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kv2019i wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ipc: do not hold a spinlock when calling schedule_ipc_worker() #10170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/ipc/ipc-common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,9 @@ void ipc_msg_send(struct ipc_msg *msg, void *data, bool high_priority)
list_item_append(&msg->list, &ipc->msg_list);
}

schedule_ipc_worker();

k_spin_unlock(&ipc->lock, key);

schedule_ipc_worker();
}
EXPORT_SYMBOL(ipc_msg_send);

Expand All @@ -265,15 +265,25 @@ static void ipc_work_handler(struct k_work *work)
{
struct ipc *ipc = ipc_get();
k_spinlock_key_t key;
bool more_to_send = false;

ipc_send_queued_msg();

key = k_spin_lock(&ipc->lock);

if (!list_is_empty(&ipc->msg_list) && !ipc->pm_prepare_D3)
schedule_ipc_worker();
more_to_send = true;

k_spin_unlock(&ipc->lock, key);

/*
* If there's a race and the message is already sent and/or
* prepare_D3 is set, we may do an extra wake-up of the
* worker, but it is harmless as the worker will take
* the lock and check the status again.
*/
if (more_to_send)
schedule_ipc_worker();
}
#endif

Expand Down
Loading