Skip to content

boards: ptl: add Google RTC Audio Processing to PTL configuration #10140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 2 commits into from
Sep 30, 2025
Merged

boards: ptl: add Google RTC Audio Processing to PTL configuration #10140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f8c712
audio: host: Add NULL check for local buffer retrieval
tmleman Sep 17, 2025
8ec2219
boards: ptl: add Google RTC Audio Processing to PTL configuration
tmleman Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/boards/intel_adsp_ace30_ptl.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ CONFIG_COMP_UP_DOWN_MIXER=y
CONFIG_COMP_VOLUME_WINDOWS_FADE=y
CONFIG_FORMAT_CONVERT_HIFI3=n

# SOF / audio modules / mocks
# This mock is part of official sof-bin releases because the CI that
# tests it can't use extra CONFIGs. See #9410, #8722 and #9386
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on line 19 contains 'CONFIGs' which should be 'CONFIG options' or 'configuration options' for clarity and grammatical correctness.

Suggested change
# tests it can't use extra CONFIGs. See #9410, #8722 and #9386
# tests it can't use extra configuration options. See #9410, #8722 and #9386

Copilot uses AI. Check for mistakes.
CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING=m
CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK=y
Copy link
Member

@lgirdwood lgirdwood Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmleman fwiw @kv2019i has been updating the configs to make them scale better with different targets. @kv2019i is this part good to merge ?

Copy link
Collaborator

@kv2019i kv2019i Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmleman @lgirdwood It's ok here if this is truly PTL specific. If it's a setting we want for all newer platforms, the it should go to the new common Intel board config file I added to main.

Copy link
Contributor Author

@tmleman tmleman Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i @lgirdwood Before adding the module on the platform, it must be tested. Ultimately, we won't be enabling this module on LNL either.
When the module is ready for WCL and NVL, we can consider moving it to a generic Kconfig. That's my opinion.


# SOF / infrastructure
CONFIG_KCPS_DYNAMIC_CLOCK_CONTROL=n
CONFIG_PROBE=y
Expand Down
5 changes: 5 additions & 0 deletions src/audio/host-legacy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,6 +716,11 @@ int host_common_params(struct host_data *hd, struct comp_dev *dev,
else
hd->local_buffer = comp_dev_get_first_data_producer(dev);

if (!hd->local_buffer) {
comp_err(dev, "no local buffer found");
return -EINVAL;
}

period_bytes = dev->frames *
audio_stream_frame_bytes(&hd->local_buffer->stream);

Expand Down
5 changes: 5 additions & 0 deletions src/audio/host-zephyr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,6 +903,11 @@ int host_common_params(struct host_data *hd, struct comp_dev *dev,
else
hd->local_buffer = comp_dev_get_first_data_producer(dev);

if (!hd->local_buffer) {
comp_err(dev, "no local buffer found");
return -EINVAL;
}

period_bytes = dev->frames * get_frame_bytes(params->frame_fmt, params->channels);

if (!period_bytes) {
Expand Down
Loading