boards: ptl: add Google RTC Audio Processing to PTL configuration #10140

tmleman · 2025-07-28T12:10:37Z

This patch introduces the Google RTC Audio Processing component into the PTL configuration for the SOF firmware. The component is added as a loadable module (m).

Changes:

Added CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING=m to enable Google RTC Audio Processing.
Included CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK=y for mock testing support.

lgirdwood

Nice to see TWB being enabled for more CI testing.

lgirdwood

LGTM

src/audio/google/google_rtc_audio_processing.c

lyakh

this looks like a debugging PR mostly, not for upstreaming? Should we modify the title to indicate that? "[DEBUG][DNM]" or similar? I'll add a "DNM" label to it to help indicate, that this isn't for merging

src/audio/google/google_rtc_audio_processing.c

src/audio/copier/copier.c

Copilot

Pull Request Overview

This PR adds Google RTC Audio Processing component support to the PTL configuration and includes null pointer validation improvements in the audio host and copier modules.

Added Google RTC Audio Processing as a loadable module with mock testing support to PTL board configuration
Enhanced null pointer validation in host audio processing functions
Added converter function pointer validation in the copier module to prevent crashes

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
app/boards/intel_adsp_ace30_ptl.conf	Enables Google RTC Audio Processing component and mock support
src/audio/host-zephyr.c	Adds null check for local_buffer to prevent errors
src/audio/host-legacy.c	Adds null check for local_buffer to prevent errors
src/audio/copier/copier.c	Adds converter function pointer validation to prevent NULL dereference

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-18T11:50:04Z

app/boards/intel_adsp_ace30_ptl.conf


+# SOF / audio modules / mocks
+# This mock is part of official sof-bin releases because the CI that
+# tests it can't use extra CONFIGs. See #9410, #8722 and #9386


The comment on line 19 contains 'CONFIGs' which should be 'CONFIG options' or 'configuration options' for clarity and grammatical correctness.

Suggested change

# tests it can't use extra CONFIGs. See #9410, #8722 and #9386

# tests it can't use extra configuration options. See #9410, #8722 and #9386

tmleman · 2025-09-18T11:54:09Z

this looks like a debugging PR mostly, not for upstreaming? Should we modify the title to indicate that? "[DEBUG][DNM]" or similar? I'll add a "DNM" label to it to help indicate, that this isn't for merging

I think it was in DRAFT to avoid merging, but I should have added something in the title for better clarity.

Add NULL pointer check after calling `comp_dev_get_first_data_consumer` and `comp_dev_get_first_data_producer` functions in host_common_params. These functions can return NULL if no appropriate buffer is found in the component's connection list. Without this check, a NULL pointer would be assigned to hd->local_buffer and could cause crashes in subsequent operations that assume a valid buffer pointer. The error handling returns -EINVAL and logs an appropriate error message to help with debugging pipeline configuration issues. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>

This patch introduces the Google RTC Audio Processing component into the PTL configuration for the SOF firmware. The component is added as a loadable module (`m`). **Changes:** - Added `CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING=m` to enable Google RTC Audio Processing. - Included `CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK=y` for mock testing support. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>

lgirdwood

@tmleman I think we need the 1st patch in v2.14 and an open on the second part now.

lgirdwood · 2025-09-22T09:35:44Z

app/boards/intel_adsp_ace30_ptl.conf

+# This mock is part of official sof-bin releases because the CI that
+# tests it can't use extra CONFIGs. See #9410, #8722 and #9386
+CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING=m
+CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK=y


@tmleman fwiw @kv2019i has been updating the configs to make them scale better with different targets. @kv2019i is this part good to merge ?

@tmleman @lgirdwood It's ok here if this is truly PTL specific. If it's a setting we want for all newer platforms, the it should go to the new common Intel board config file I added to main.

@kv2019i @lgirdwood Before adding the module on the platform, it must be tested. Ultimately, we won't be enabling this module on LNL either.
When the module is ready for WCL and NVL, we can consider moving it to a generic Kconfig. That's my opinion.

kv2019i

+1 with the assumption this specifically needs to be PTL specific.

tmleman · 2025-09-23T11:16:19Z

SOFCI TEST

tmleman force-pushed the topic/upstream/pr/intel/adsp/ptl/google_rtc branch 2 times, most recently from 8b762e7 to 369ad4a Compare August 6, 2025 12:33

lgirdwood reviewed Aug 7, 2025

View reviewed changes

tmleman force-pushed the topic/upstream/pr/intel/adsp/ptl/google_rtc branch from 73acee1 to 8980eb1 Compare August 8, 2025 19:16

tmleman force-pushed the topic/upstream/pr/intel/adsp/ptl/google_rtc branch from 8980eb1 to be014ea Compare August 27, 2025 13:42

lgirdwood reviewed Aug 27, 2025

View reviewed changes

src/audio/google/google_rtc_audio_processing.c Outdated Show resolved Hide resolved

tmleman force-pushed the topic/upstream/pr/intel/adsp/ptl/google_rtc branch from be014ea to e23f9b1 Compare September 17, 2025 07:51

lyakh reviewed Sep 18, 2025

View reviewed changes

src/audio/google/google_rtc_audio_processing.c Outdated Show resolved Hide resolved

src/audio/copier/copier.c Outdated Show resolved Hide resolved

src/audio/copier/copier.c Outdated Show resolved Hide resolved

lyakh added the DNM Do Not Merge tag label Sep 18, 2025

tmleman changed the title ~~boards: ptl: add Google RTC Audio Processing to PTL configuration~~ [WIP] boards: ptl: add Google RTC Audio Processing to PTL configuration Sep 18, 2025

tmleman force-pushed the topic/upstream/pr/intel/adsp/ptl/google_rtc branch from b37bb25 to d927de5 Compare September 18, 2025 11:46

tmleman removed the DNM Do Not Merge tag label Sep 18, 2025

tmleman changed the title ~~[WIP] boards: ptl: add Google RTC Audio Processing to PTL configuration~~ boards: ptl: add Google RTC Audio Processing to PTL configuration Sep 18, 2025

tmleman marked this pull request as ready for review September 18, 2025 11:49

Copilot AI review requested due to automatic review settings September 18, 2025 11:49

tmleman requested review from RanderWang, abonislawski, dbaluta, kv2019i, lbetlej, mmaka1, pblaszko and plbossart as code owners September 18, 2025 11:49

Copilot AI reviewed Sep 18, 2025

View reviewed changes

tmleman requested review from lgirdwood and lyakh September 18, 2025 12:01

tmleman force-pushed the topic/upstream/pr/intel/adsp/ptl/google_rtc branch 2 times, most recently from 15edda6 to 8ec2219 Compare September 22, 2025 07:12

lgirdwood reviewed Sep 22, 2025

View reviewed changes

kv2019i approved these changes Sep 22, 2025

View reviewed changes

lgirdwood approved these changes Sep 30, 2025

View reviewed changes

lgirdwood merged commit c1b673e into thesofproject:main Sep 30, 2025
37 of 45 checks passed

	# tests it can't use extra CONFIGs. See #9410, #8722 and #9386
	# tests it can't use extra configuration options. See #9410, #8722 and #9386

boards: ptl: add Google RTC Audio Processing to PTL configuration #10140

boards: ptl: add Google RTC Audio Processing to PTL configuration #10140

Uh oh!

Conversation

tmleman commented Jul 28, 2025

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lyakh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

tmleman commented Sep 18, 2025

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

kv2019i Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

tmleman Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

tmleman commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants