Open
Conversation
* Add initial skill for testing, which is simply Steve's skill * Rename skill to 'temporal-dev' and update version Updated skill name and version for Temporal Python.
* Use claude to merge Steve's, Max's, and Mason's skills. Did a review pass using claude's skill devlopment skills * Add missing things from Steve * trigger tweaks * Add in common gotchas from Johann
4 tasks
cretz
reviewed
Feb 10, 2026
|
|
||
| ### Synchronous Activities | ||
|
|
||
| - Run in the `activity_executor` (thread pool by default) |
| For CPU-bound work or true parallelism: | ||
|
|
||
| - Use multiple worker processes | ||
| - Or use `ProcessPoolExecutor` for synchronous activities |
Member
There was a problem hiding this comment.
We should discourage this or at least explain some downsides (e.g. cancellation delivery)
|
|
||
| ## Local Test Environment | ||
|
|
||
| For tests that don't need time-skipping: |
Member
There was a problem hiding this comment.
Specifically, should say in the previous section that Time-Skipping Test Environment should only be when you must have time-skipping
| env = ActivityEnvironment() | ||
|
|
||
| # Optionally customize activity info | ||
| # env.info = ActivityInfo(...) |
Member
There was a problem hiding this comment.
We have a newer suggestion which is using dataclasses.replace with the ActivityEnvironment.default info()
|
|
||
| @pytest.mark.asyncio | ||
| async def test_with_mock(): | ||
| async with await WorkflowEnvironment.start_time_skipping() as env: |
Member
There was a problem hiding this comment.
Mentioned before, but we should stop using time skipping unless we really need it, it's a poor test env (can't be reused, limited functionality, etc)
Member
|
Note, I did not review TypeScript, only core and Python. |
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do NOT merge until good for releasing 0.1.0