apollo_config_manager: remove config manager client from runner#13643
Open
ArniStarkware wants to merge 1 commit intoarni/apollo_node/replace_with_config_manager_channel_clientfrom
Conversation
|
This change is |
This was referenced Apr 2, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 2, 2026
ArniStarkware
force-pushed
the
arni/config_manager/remove_client_from_runner
branch
from
82fbdbd to
251ce2d
Compare
ArniStarkware
force-pushed
the
arni/apollo_node/replace_with_config_manager_channel_client
branch
from
1740635 to
e853e68
Compare
ArniStarkware
force-pushed
the
arni/config_manager/remove_client_from_runner
branch
from
251ce2d to
c8c1f2a
Compare
ArniStarkware
force-pushed
the
arni/config_manager/remove_client_from_runner
branch
from
c8c1f2a to
855e877
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Moderate risk because it changes how dynamic config updates are propagated (removes the runner’s remote client update path) and could affect components that relied on the previous side effect. Scope is contained to config update plumbing and tests.
Overview
ConfigManagerRunnerno longer depends on aSharedConfigManagerClient; it now propagates config changes only by sending the newNodeDynamicConfigover thewatchchannel, with simplified logging/error handling.Node component wiring and runner tests are updated accordingly: construction of the runner drops the client parameter, and watcher tests now assert updates by observing the
watchchannel rather than mockingset_node_dynamic_configcalls.Written by Cursor Bugbot for commit 855e877. This will update automatically on new commits. Configure here.