apollo_http_server: add client with channel to http server

[ArniStarkware]

Note

Medium Risk
Medium risk because it changes how HttpServer obtains dynamic configuration (adding a second source with expect-based failure) and updates construction/wiring across node startup and tests, which could impact runtime availability if the reader client isn’t provided or diverges.

Overview
HttpServer now accepts and stores a SharedConfigManagerReaderClient in AppState, and get_dynamic_config() fetches the dynamic config from this reader, expects it to be available, and warns if it differs from the existing dynamic_config_rx value.

Construction/wiring is updated accordingly: create_http_server()/HttpServer::new() take the new reader client, node component creation passes it via get_config_manager_reader_client(), and http-server tests/utilities add builder support plus mocks for the new reader client.

^{Reviewed by Cursor Bugbot for commit 646823f. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[ArniStarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_infra,apollo_node: get_local_client panics for non-local clients #13667
• apollo_gateway,apollo_config_manager_types: use config manager channel client for dynamic config #13666
• apollo_config_manager_types: rename ConfigManagerChannelClient to ConfigManagerClient #13658
• apollo_config_manager_types: remove deprecated config manager RPC infrastructure #13645
• apollo_config_manager,apollo_node: remove ConfigManager #13644
• apollo_config_manager: remove config manager client from runner #13643
• apollo_node: replace config manager client with channel client #13581
• apollo_http_server: remove use of deprecated config manager shared client #13567
• apollo_http_server: add client with channel to http server #13566 👈 (View in Graphite)
• apollo_node,apollo_config_manager: add config manager reader client to node #13706
• apollo_infra,apollo_config_manager_types: add reader client variant for watch-channel-based clients #13705 : 1 other dependent PR (#13731 )
• apollo_infra: create component clients with channel #13565 : 1 other dependent PR (#13568 )
• apollo_config_manager: add sender channel to the config manager runner #13477
• apollo_infra: refactor client struct to be an enum #13570
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4542533. Configure here.}

[nadin-Starkware]

@nadin-Starkware made 1 comment.
Reviewable status: 1 of 8 files reviewed, 1 unresolved discussion (waiting on ArniStarkware).

[nadin-Starkware]

@nadin-Starkware reviewed 7 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArniStarkware).

[ArniStarkware]

@ArniStarkware reviewed 2 files.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArniStarkware).

[cursor]

PR Summary

Medium Risk
Introduces a new config source for HTTP server dynamic config and adds a hard expect that can panic if the reader client fails, plus new wiring across node startup and tests. Overall behavior should be unchanged but misconfiguration or reader/client divergence could surface at runtime via warnings/panics.

Overview
The HTTP server now accepts and stores a LocalConfigManagerReaderClient in AppState, and get_dynamic_config() fetches dynamic config from this reader to cross-check the existing watch-channel config, logging a warning on mismatch (while still using the channel value for now).

Construction is updated end-to-end (HttpServer::new, create_http_server, and node components.rs) to pass the reader client, and tests/test utilities add a MockConfigManagerReaderClient plus builder plumbing so unit tests can configure both config clients consistently.

^{Reviewed by Cursor Bugbot for commit f9e8f6c. Bugbot is set up for automated code reviews on this repo. Configure here.}