Update encoding notices for string literals #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bob-carpenter
requested changes
Aug 31, 2021
Member
bob-carpenter
left a comment
bob-carpenter
left a comment
There was a problem hiding this comment.
Ack. Forgot to send this the other day.
Member
Author
|
Made another round of edits based on your suggestions. Let me know if I mangled your meaning anywhere |
bob-carpenter
approved these changes
Aug 31, 2021
Member
bob-carpenter
left a comment
bob-carpenter
left a comment
There was a problem hiding this comment.
Great. Thanks for bearing with me on the picky details of how to talk about encodings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
This is the doc component of stan-dev/stanc3#952
stanc3 now escapes string literals in a way that C++ can understand, meaning the only barrier to users putting unicode (or other encodings) of characters in string literals is their own system environment.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: