Skip to content

Eliminate redundant data processing in mcmc_areas_data()#501

Open
utkarshpawade wants to merge 2 commits intostan-dev:masterfrom
utkarshpawade:perf/mcmc-areas-data-redundant-processing
Open

Eliminate redundant data processing in mcmc_areas_data()#501
utkarshpawade wants to merge 2 commits intostan-dev:masterfrom
utkarshpawade:perf/mcmc-areas-data-redundant-processing

Conversation

@utkarshpawade
Copy link
Contributor

Fixes #500

Summary

  • Call prepare_mcmc_array(), merge_chains(), and melt_mcmc() once at the top of mcmc_areas_data()
  • Pass pre-computed data_long into mcmc_intervals_data() via an internal .data_long parameter

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.67%. Comparing base (042663b) to head (1d6bd1f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #501   +/-   ##
=======================================
  Coverage   98.66%   98.67%           
=======================================
  Files          35       35           
  Lines        5864     5865    +1     
=======================================
+ Hits         5786     5787    +1     
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mcmc_areas_data() processes MCMC array three times redundantly

2 participants