Add structured status conditions for ToolConfigRef and ExternalAuthConfigRef validation #3634
+266
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJBurns
requested review from
JAORMX,
jerm-dro,
jhrozek and
yrobla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3634 +/- ##
==========================================
- Coverage 65.96% 65.93% -0.03%
==========================================
Files 415 415
Lines 41144 41192 +48
==========================================
+ Hits 27140 27161 +21
- Misses 11909 11936 +27
Partials 2095 2095 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
size/S
ChrisJBurns
force-pushed
the
mcpremoteproxy-status-conditions
branch
from
6a18cb7 to
88ab2f8
Compare
github-actions
bot
added
size/S
jhrozek
previously approved these changes
Feb 5, 2026
ChrisJBurns
force-pushed
the
mcpremoteproxy-status-conditions
branch
from
88ab2f8 to
b2bb855
Compare
github-actions
bot
added
size/M
…nfigRef validation Add dedicated ToolConfigValidated and ExternalAuthConfigValidated status conditions to the MCPRemoteProxy controller, following the existing GroupRefValidated pattern. Use errors.IsNotFound to distinguish not-found (ToolConfigNotFound, ExternalAuthConfigNotFound) from transient API errors (ToolConfigFetchError, ExternalAuthConfigFetchError). Add comprehensive condition assertions and fetch error test cases using client interceptors. Closes #3607 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ChrisJBurns
force-pushed
the
mcpremoteproxy-status-conditions
branch
from
b2bb855 to
41f8413
Compare
github-actions
bot
added
size/M
jhrozek
approved these changes
Feb 5, 2026
github-actions
bot
added
size/M
ChrisJBurns
added a commit
that referenced
this pull request
Feb 6, 2026
Update MCPRemoteProxy integration tests to use the structured status conditions added in #3634 for ToolConfigRef and ExternalAuthConfigRef validation: - ToolConfigRef "not found": Assert ToolConfigValidated=False with ToolConfigNotFound reason and config name in message - ToolConfigRef "success": Assert ToolConfigValidated=True with ToolConfigValid reason - ExternalAuthConfigRef "not found": Assert AuthConfigured=False with AuthInvalid reason - ExternalAuthConfigRef "success": Assert ExternalAuthConfigValidated=True with ExternalAuthConfigValid reason Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ToolConfigValidatedandExternalAuthConfigValidatedstatus conditions to the MCPRemoteProxy controller, following the existingGroupRefValidatedpatternToolConfigFetchError,ExternalAuthConfigFetchError) from resource-not-found (ToolConfigNotFound,ExternalAuthConfigNotFound) for clearer programmatic diagnosticsCloses #3607
Test plan
🤖 Generated with Claude Code