Add integration tests for MCPRemoteProxy resource references#3608
Open
ChrisJBurns wants to merge 6 commits intomainfrom
Open
Add integration tests for MCPRemoteProxy resource references#3608ChrisJBurns wants to merge 6 commits intomainfrom
ChrisJBurns wants to merge 6 commits intomainfrom
Conversation
Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
- Add WaitForPhase helper to reduce test duplication - Add WaitForStatusMessage helper for status message assertions - Update ExternalAuthConfigRef and ToolConfigRef tests to use helpers - Improve "not found" assertions to verify both config name and "not found" substring for stronger validation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1f6e931 to
fa890fc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3608 +/- ##
==========================================
- Coverage 65.77% 65.72% -0.06%
==========================================
Files 411 411
Lines 40727 40727
==========================================
- Hits 26790 26767 -23
- Misses 11853 11877 +24
+ Partials 2084 2083 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The MCPGroup controller requires a field index for MCPServer.Spec.GroupRef to list servers belonging to a group. This was missing from the mcp-remote-proxy test suite, causing failures when tests created MCPGroups. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- ToolConfigRef "not found" test: Adjusted assertion to check only Phase=Failed since the controller doesn't set status.Message for ToolConfig validation failures (only logs the error). This is tracked in issue #3607. - GroupRef "not Ready" test: Removed test that tried to manually set MCPGroup status to Pending, which doesn't work because the MCPGroup controller immediately reconciles empty groups to Ready state. - GroupRef transition test: Changed from testing "not ready -> ready" to testing "not found -> found and ready", which avoids the race condition with the MCPGroup controller. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WaitForPhase)WithExternalAuthConfigRef,WithToolConfigRef,WithGroupRef)Test Coverage Added
ExternalAuthConfigRef Integration (3 tests)
ToolConfigRef Integration (3 tests)
GroupRef Integration (5 tests)
Test plan
go vetandgofmtRelated Issues
Closes #3362 (Integration with Other Resources section)
See also #3607 for a follow-up to add structured status conditions for ToolConfigRef and ExternalAuthConfigRef validation.
🤖 Generated with Claude Code