Open
Conversation
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR documents the new toolhive.stacklok.dev/tool-definitions annotation that allows registry users to specify MCP tool metadata directly in Kubernetes resource annotations. This feature enables tool discovery information to be embedded in the registry without requiring separate API calls.
Changes:
- Added documentation for the
tool-definitionsannotation in the registry configuration guide - Included a YAML example showing how to specify tool definitions in annotations
- Explained validation behavior, API response format, and supported metadata fields
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
Contributor
Author
|
@copilot re-review the changes after addressed feedback |
Contributor
Author
|
@copilot re-review the changes in this PR, do not create a new PR nor attempt to do any code changes. Just re-review |
4 tasks
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
Collaborator
|
@lujunsan I'm not up to speed on this feature in the registry so it would be better if someone else from the team reviews this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolhive.stacklok.dev/tool-definitionsannotationRelated
Implements documentation for stacklok/toolhive-registry-server#414 (registry-server implementation of RFC-0015)
Changes
docs/toolhive/guides-registry/configuration.mdx:tool-definitionsannotation to the annotations table