Skip to content

docs: update suggestions to use "set" and "unset" environment commands #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zimeg wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

docs: update suggestions to use "set" and "unset" environment commands #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/STYLE_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ The square brackets surrounding command arguments hint that these are optional:

```
USAGE
$ slack env add [name] [value] [flags]
$ slack env set [name] [value] [flags]
```

The angled brackets around arguments hint that these are required:
Expand Down
4 changes: 2 additions & 2 deletions cmd/env/unset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func runEnvUnsetCommandFunc(clients *shared.ClientFactory, cmd *cobra.Command, a
Emoji: "evergreen_tree",
Text: "Environment Unset",
Secondary: []string{
"The app has no environment variables to remove",
"The app has no environment variables to unset",
},
}))
return nil
Expand Down Expand Up @@ -141,7 +141,7 @@ func runEnvUnsetCommandFunc(clients *shared.ClientFactory, cmd *cobra.Command, a
Emoji: "evergreen_tree",
Text: "Environment Unset",
Secondary: []string{
"The project has no environment variables to remove",
"The project has no environment variables to unset",
},
}))
return nil
Expand Down
4 changes: 2 additions & 2 deletions cmd/env/unset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func Test_Env_RemoveCommand(t *testing.T) {
cm.API.AssertNotCalled(t, "RemoveVariable")
},
ExpectedStdoutOutputs: []string{
"The project has no environment variables to remove",
"The project has no environment variables to unset",
},
},
"exit without errors when hosted app has zero variables": {
Expand All @@ -94,7 +94,7 @@ func Test_Env_RemoveCommand(t *testing.T) {
cm.API.AssertNotCalled(t, "RemoveVariable")
},
ExpectedStdoutOutputs: []string{
"The app has no environment variables to remove",
"The app has no environment variables to unset",
},
},
"remove a hosted variable using arguments": {
Expand Down
2 changes: 1 addition & 1 deletion internal/auth/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ func (c *Client) ResolveAPIHost(ctx context.Context, apiHostFlag string, customA
c.io.PrintDebug(
ctx,
"You're using a custom apihost. Run %s to add it to your app's Run on Slack environment",
style.Commandf(fmt.Sprintf("var add SLACK_API_URL %s", apiHost), false),
style.Commandf(fmt.Sprintf("env set SLACK_API_URL %s", apiHost), false),
)
}

Expand Down
Loading