docs: update suggestions to use "set" and "unset" environment commands#525
Open
docs: update suggestions to use "set" and "unset" environment commands#525
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
env add and env remove references to set/unsetenv add and env remove references to set/unset
env add and env remove references to set/unset
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
==========================================
- Coverage 71.27% 71.27% -0.01%
==========================================
Files 222 222
Lines 18682 18682
==========================================
- Hits 13316 13315 -1
+ Misses 4187 4185 -2
- Partials 1179 1182 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
The
envcommands are suggested in a few places and some of these places were updated to use the preferred aliasessetandunset.Summary
This pull request updates leftover references to the old
env addandenv removecommand names that were missed whensetandunsetbecame the primary commands in #460..github/STYLE_GUIDE.md: Example usage updated fromenv addtoenv setcmd/env/unset.go: User-facing "no variables to remove" messages changed to "unset"internal/auth/auth.go: Debug message updated fromvar add SLACK_API_URLtoenv set SLACK_API_URLPreview
N/A — text-only changes to output messages and docs.
Testing
slack env unsetin a project with no.envfile and confirm the message says "no environment variables to unset"env set SLACK_API_URLNotes
Follow-up to #460.
Requirements