Skip to content

Fix server goroutine leak: add deadline to forwardRequest handshake #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0pcom merged 1 commit into from
Apr 8, 2026
Merged

Fix server goroutine leak: add deadline to forwardRequest handshake #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/dmsg/server_session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,12 +366,22 @@ func (ss *ServerSession) forwardRequest(req StreamRequest) (mStr io.ReadWriteClo
return nil, nil, err
}
}
// Set a deadline for the forwarding handshake. If the destination visor
// accepts the stream but never responds, readObject blocks forever,
// leaking goroutines. Observed as 2K+ stuck goroutines per DMSG server.
if conn, ok := mStr.(net.Conn); ok {
conn.SetDeadline(time.Now().Add(HandshakeTimeout)) //nolint:errcheck,gosec
}
if err = ss.writeObject(mStr, req.raw); err != nil {
return nil, nil, err
}
if respObj, err = ss.readObject(mStr); err != nil {
return nil, nil, err
}
// Clear deadline before returning the stream for long-lived bridging.
if conn, ok := mStr.(net.Conn); ok {
conn.SetDeadline(time.Time{}) //nolint:errcheck,gosec
}
var resp StreamResponse
if resp, err = respObj.ObtainStreamResponse(); err != nil {
return nil, nil, err
Expand Down