Fix server goroutine leak: add deadline to forwardRequest handshake#374
Merged
0pcom merged 1 commit intoskycoin:developfrom Apr 8, 2026
Merged
Conversation
forwardRequest opens a stream to the destination and reads the response. If the destination accepts but never responds, readObject blocks forever — observed as 2.4K+ stuck goroutines per server, growing rapidly after restart. The idle timeout fix (PR skycoin#372) only covered the bridge phase (CopyReadWriteCloser). This adds HandshakeTimeout to the forwardRequest handshake read, matching the client-side behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add HandshakeTimeout deadline to forwardRequest's readObject call.
Root cause
forwardRequest opens a yamux stream to the destination visor and reads the handshake response. If the destination accepts the stream but never responds (dead visor, stuck process), readObject blocks forever. Observed as 2,400+ stuck goroutines per DMSG server minutes after restart.
The idle timeout fix (PR #372) only covered the bridge phase after handshake completion. The forwardRequest handshake itself had no timeout.
Fix
Set HandshakeTimeout deadline before write/read, clear it after handshake completes (before returning the stream for long-lived bridging).