Skip to content

SF-3700 Fix audio comments created offline to be playable when online #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmachapman merged 1 commit into from
Feb 11, 2026
Merged

SF-3700 Fix audio comments created offline to be playable when online #3667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/SIL.XForge.Scripture/ClientApp/src/app/core/models/question-doc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,18 @@ export class QuestionDoc extends ProjectDataDoc<Question> {
// The file belongs to the question
return obj<Question>().path(q => q.audioUrl);
} else {
// otherwise, it is probably belongs to an answer
const answerIndex = this.data.answers.findIndex(a => a.dataId === dataId && !a.deleted);
if (answerIndex !== -1) {
return obj<Question>().path(q => q.answers[answerIndex].audioUrl);
// Otherwise, it might belong to an answer
for (let answerIndex = 0; answerIndex < this.data.answers.length; answerIndex++) {
const answer = this.data.answers[answerIndex];
if (answer.dataId === dataId && !answer.deleted) {
return obj<Question>().path(q => q.answers[answerIndex].audioUrl);
}

// Or a comment in the answer
const commentIndex = answer.comments.findIndex(c => c.dataId === dataId && !c.deleted);
if (commentIndex !== -1) {
return obj<Question>().path(q => q.answers[answerIndex].comments[commentIndex].audioUrl);
}
}
}
return undefined;
Expand Down
Loading