Skip to content

SF-3700 Fix audio comments created offline to be playable when online#3667

Merged
pmachapman merged 1 commit intomasterfrom
fix/SF-3700
Feb 11, 2026
Merged

SF-3700 Fix audio comments created offline to be playable when online#3667
pmachapman merged 1 commit intomasterfrom
fix/SF-3700

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Feb 3, 2026

This PR fixes a bug where the comment's audioUrl was not correctly updated when an audio comment was created offline


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.91%. Comparing base (4cdf89f) to head (66cf2e7).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ture/ClientApp/src/app/core/models/question-doc.ts 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3667      +/-   ##
==========================================
- Coverage   81.91%   81.91%   -0.01%     
==========================================
  Files         618      618              
  Lines       38561    38565       +4     
  Branches     6286     6287       +1     
==========================================
+ Hits        31588    31589       +1     
- Misses       6012     6015       +3     
  Partials      961      961              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@RaymondLuong3 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman).

@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Feb 10, 2026
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Feb 11, 2026
@pmachapman pmachapman merged commit e44b0a4 into master Feb 11, 2026
23 checks passed
@pmachapman pmachapman deleted the fix/SF-3700 branch February 11, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants