Skip to content

Fix LT-18897: FLEx is silently changing completed analyses #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtmaxwell3 merged 2 commits into from
May 26, 2026
+20 −2
Merged

Fix LT-18897: FLEx is silently changing completed analyses #378

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46be7ee
Fix LT-18897: FLEx is silently changing completed analyses
jtmaxwell3 May 26, 2026
04c8e4e
Remove parameters from summary as requested
jtmaxwell3 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/SIL.LCModel/DomainImpl/AnalysisAdjuster.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1455,9 +1455,9 @@ private void DetermineWhatToMove(int ichSource, int cchInsert, IStTxtPara source
else if (cchInsert > 0 && seg.EndOffset <= ichSource + cchInsert)
m_segPartlyMoved = seg;
}
if (m_segPartlyMoved != null && m_segPartlyMoved.EndOffset == ichSource)
if (m_segPartlyMoved != null && DeltaIsEmpty(m_segPartlyMoved.EndOffset, ichSource, source))
{
// We are splitting the paragraph right at a segment boundary so there is
// We are splitting the paragraph at the equivalent of a segment boundary so there is
// no need to copy this segment (as if it was split in the middle of this segment).
m_segPartlyMoved = null;
}
Expand All @@ -1474,6 +1474,24 @@ private void DetermineWhatToMove(int ichSource, int cchInsert, IStTxtPara source
}
}

/// <summary>
/// Is the delta between the old segment boundary and the new segment boundary empty?
/// This fixes LT-18897.
/// </summary>
private bool DeltaIsEmpty(int endOffset, int ichSource, IStTxtPara source)
{
int start = Math.Min(endOffset, ichSource);
int end = Math.Max(endOffset, ichSource);
for (int i = start; i < end; i++)
{
if (!Char.IsWhiteSpace(source.Contents.Text[i]))
{
return false;
}
}
return true;
}

private List<IAnalysisReference> MoveAnalysisAndReferencesFromOldPara(int cchInsert,
IStTxtPara source, bool fParaIsNew)
{
Expand Down
Loading