Fix LT-18897: FLEx is silently changing completed analyses#378
Merged
Conversation
mark-sil
reviewed
May 26, 2026
| /// <param name="endOffset"></param> | ||
| /// <param name="ichSource"></param> | ||
| /// <param name="source"></param> | ||
| /// <returns></returns> |
Contributor
There was a problem hiding this comment.
Probably should not include the comments for the params and the return if they don't contain any information.
mark-sil
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-18897. AnalysisAdjuster wasn't recognizing that a segment basically hadn't changed if it included some extra white space. I added DeltaIsEmpty to catch this case. So, adding a paragraph break anywhere between two segments should work now.
This change is