Skip to content

Reset install state on dialog toggle and simplify UpdateDialog rendering#2182

Draft
myieye wants to merge 1 commit intodevelopfrom
codex/fix-typeerror-in-update-dialog
Draft

Reset install state on dialog toggle and simplify UpdateDialog rendering#2182
myieye wants to merge 1 commit intodevelopfrom
codex/fix-typeerror-in-update-dialog

Conversation

@myieye
Copy link
Collaborator

@myieye myieye commented Feb 26, 2026

When closing the Update drawer (i.e. [only] on mobile) you currently get the error:

Uncaught TypeError: is not a function TypeError: opts.onAnimationEnd.current is not a function at http://localhost:5173/node_modules/.vite/deps/vaul-svelte.js?v=76104f81:1104:38

The reason is the fact that I wrapped the dialog/drawer in {#if open} to ensure state resets between openings.
Instead, we'll just manually reset all state.


Codex Task

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/fix-typeerror-in-update-dialog

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Feb 26, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

UI unit Tests

  1 files  ±0   50 suites  ±0   24s ⏱️ -2s
138 tests ±0  138 ✅ ±0  0 💤 ±0  0 ❌ ±0 
203 runs  ±0  203 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 22adf31. ± Comparison against base commit d3a5b3e.

♻️ This comment has been updated with latest results.

@argos-ci
Copy link

argos-ci bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Feb 26, 2026, 10:59 AM

@github-actions
Copy link
Contributor

C# Unit Tests

160 tests  ±0   160 ✅ ±0   18s ⏱️ ±0s
 23 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 22adf31. ± Comparison against base commit d3a5b3e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant