Skip to content

Python(chore): remove default logger configuration to leave to implementation #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexluck-sift merged 2 commits into from
Sep 30, 2025
Merged

Python(chore): remove default logger configuration to leave to implementation #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99f7905
remove default logger configuration to leave to implementation
alexluck-sift Sep 26, 2025
221e3c8
lint
alexluck-sift Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions python/lib/sift_client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ async def get_asset_async():
"""

import logging
import sys

from sift_client.client import SiftClient
from sift_client.transport import SiftConnectionConfig
Expand All @@ -213,11 +212,4 @@ async def get_asset_async():
"SiftConnectionConfig",
]

logger = logging.getLogger("sift_client")
logging.basicConfig(
level=logging.ERROR, format="%(asctime)s - %(name)s - %(levelname)s - %(message)s"
)


handler = logging.StreamHandler(sys.stdout)
logger.addHandler(handler)
logging.getLogger(__name__).addHandler(logging.NullHandler())
4 changes: 0 additions & 4 deletions python/lib/sift_client/_internal/low_level_wrappers/assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from __future__ import annotations

import logging
from typing import Any, cast

from sift.assets.v1.assets_pb2 import (
Expand All @@ -20,9 +19,6 @@
from sift_client.sift_types.asset import Asset, AssetUpdate
from sift_client.transport import GrpcClient, WithGrpcClient

# Configure logging
logger = logging.getLogger(__name__)


class AssetsLowLevelClient(LowLevelClientBase, WithGrpcClient):
"""Low-level client for the AssetsAPI.
Expand Down
Loading