Skip to content

Python(chore): remove default logger configuration to leave to implementation#325

Merged
alexluck-sift merged 2 commits intomainfrom
python/chore/default-logger
Sep 30, 2025
Merged

Python(chore): remove default logger configuration to leave to implementation#325
alexluck-sift merged 2 commits intomainfrom
python/chore/default-logger

Conversation

@alexluck-sift
Copy link
Collaborator

Removes the logger configuration such that it can be exclusively defined by the customer code.

For example:

import logging
from sift_client import SiftClient

# Configure logging
logging.basicConfig(level=logging.INFO)

# Fine-grained control
logging.getLogger('sift_client').setLevel(logging.DEBUG)                    # All sift_client logs
logging.getLogger('sift_client.resources').setLevel(logging.WARNING)       # Only resource logs  
logging.getLogger('sift_client.resources.assets').setLevel(logging.ERROR)  # Only asset logs
logging.getLogger('sift_client.transport').setLevel(logging.INFO)          # Only transport logs

client = SiftClient(...)

@alexluck-sift alexluck-sift force-pushed the python/chore/default-logger branch from 505c76b to 221e3c8 Compare September 29, 2025 23:33
Copy link
Contributor

@nathan-sift nathan-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The feedback on the NullHandler is optional

@alexluck-sift alexluck-sift merged commit 73eb0c5 into main Sep 30, 2025
10 checks passed
@alexluck-sift alexluck-sift deleted the python/chore/default-logger branch September 30, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants