Skip to content

refactor: migrate to goreleaser native Cloudsmith support #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Soner (shyim) merged 1 commit into from
May 21, 2026
+10 −16
Merged

refactor: migrate to goreleaser native Cloudsmith support #1046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,20 +94,4 @@ jobs:
APPLE_APP_STORE_CONNECT_ISSUER: ${{ secrets.APPLE_APP_STORE_CONNECT_ISSUER }}
APPLE_APP_STORE_CONNECT_KEY_ID: ${{ secrets.APPLE_APP_STORE_CONNECT_KEY_ID }}
APPLE_APP_STORE_CONNECT_KEY: ${{ secrets.APPLE_APP_STORE_CONNECT_KEY }}

- name: Install Cloudsmith CLI
run: pip install --upgrade cloudsmith-cli

- name: Cloudsmith Uploads
env:
CLOUDSMITH_API_KEY: ${{ secrets.CLOUDSMITH_API_KEY }}
run: |
for filename in dist/*.deb; do
cloudsmith push deb friendsofshopware/stable/any-distro/any-version $filename
done
for filename in dist/*.rpm; do
cloudsmith push rpm friendsofshopware/stable/any-distro/any-version $filename
done
for filename in dist/*.apk; do
cloudsmith push alpine friendsofshopware/stable/alpine/any-version $filename
done
10 changes: 10 additions & 0 deletions .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,16 @@ npms:
access: public
tag: '{{ if .Prerelease }}prerelease{{ else }}latest{{ end }}'

cloudsmiths:
- organization: friendsofshopware
repository: stable
secret_name: CLOUDSMITH_API_KEY
disable: '{{ if .Prerelease }}true{{ end }}'
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace unsupported Cloudsmith disable key with skip

In the new cloudsmiths block, disable is not a valid Cloudsmith config field in GoReleaser (the Cloudsmith publisher docs list skip for conditional publishing), so this can break goreleaser release with a config unmarshal/validation error, or at minimum fail to gate prerelease uploads as intended. Because this runs inside .github/workflows/release.yml for every tag, a bad key here can block the entire release job instead of only Cloudsmith publishing.

Useful? React with 👍 / 👎.

distributions:
deb: "any-distro/any-version"
rpm: "any-distro/any-version"
alpine: "alpine/any-version"

notarize:
macos:
- enabled: '{{ isEnvSet "APPLE_CODE_SIGNING_KEY" }}'
Expand Down