refactor: migrate to goreleaser native Cloudsmith support#1046
Conversation
Replace manual cloudsmith-cli pip install and push steps in the release workflow with goreleaser's built-in cloudsmiths configuration. This simplifies the pipeline and moves package distribution logic into the goreleaser config where it belongs. 💘 Generated with Crush Assisted-by: Crush:deepseek-v4-flash
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cc11948ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| - organization: friendsofshopware | ||
| repository: stable | ||
| secret_name: CLOUDSMITH_API_KEY | ||
| disable: '{{ if .Prerelease }}true{{ end }}' |
There was a problem hiding this comment.
disable key with skip
In the new cloudsmiths block, disable is not a valid Cloudsmith config field in GoReleaser (the Cloudsmith publisher docs list skip for conditional publishing), so this can break goreleaser release with a config unmarshal/validation error, or at minimum fail to gate prerelease uploads as intended. Because this runs inside .github/workflows/release.yml for every tag, a bad key here can block the entire release job instead of only Cloudsmith publishing.
Useful? React with 👍 / 👎.
1 participant
Summary
cloudsmith-clipip install and push steps inrelease.ymlwith goreleaser's built-incloudsmithsconfiguration in.goreleaser.yamlcloudsmith-cliPython package and lets goreleaser handle distribution uploads nativelyTest plan
💘 Generated with Crush