ECTO-2519 - improve IAP checkout subscription change UI#137
Open
Jannik (qysp) wants to merge 1 commit intoevaluation/ECTO-2555from
Open
ECTO-2519 - improve IAP checkout subscription change UI#137Jannik (qysp) wants to merge 1 commit intoevaluation/ECTO-2555from
Jannik (qysp) wants to merge 1 commit intoevaluation/ECTO-2555from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the in-app-purchase checkout subscription change UI by refining displayed plan details (names, durations, hints) and tightening up related typing/i18n.
Changes:
- Introduces a shared
InAppPurchaseVarianttype and aligns cart/subscription-change typing (includingnextBookingDateasstring). - Updates the subscription change component UI/computed props (plan names, durations, prorated price handling, upgrade vs downgrade hint text).
- Adjusts i18n snippets (duration labels, separate upgrade/downgrade hints, variant labels) and improves currency formatting in checkout overview options.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Resources/app/administration/src/module/sw-in-app-purchases/types/index.ts | Adds InAppPurchaseVariant and updates related type fields (variant typing, nextBookingDate). |
| src/Resources/app/administration/src/module/sw-in-app-purchases/snippet/en.json | Updates duration wording and adds separate upgrade/downgrade hints + variant labels. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/snippet/de.json | Same as EN, with German wording updates. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/sw-in-app-purchase-checkout-subscription-change.spec.js | Expands/updates unit tests for new computed props and hint behavior. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/sw-in-app-purchase-checkout-subscription-change.scss | Adds truncation/layout styling for plan names and fixes selector typo. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/sw-in-app-purchase-checkout-subscription-change.html.twig | Updates markup to show plan names, conditional durations, conditional hint, and uses new computed props. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/index.ts | Refactors computed logic (durations, hint text, prorated logic, year formatting). |
| src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-overview/index.ts | Uses currency filter + duration translation to build more user-friendly purchase option labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...odule/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/index.ts
Outdated
Show resolved
Hide resolved
...p-purchase-checkout-subscription-change/sw-in-app-purchase-checkout-subscription-change.scss
Show resolved
Hide resolved
Jannik (qysp)
force-pushed
the
refactoring/ECTO-2519
branch
from
b8f939c to
cf3972b
Compare
Jannik (qysp)
force-pushed
the
refactoring/ECTO-2519
branch
from
cf3972b to
977d5a6
Compare
Michel (cyl3x)
approved these changes
Mar 20, 2026
Contributor
|
This probably should be backported to 6.6.x as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It kinda builds up on the previous ticket (ECTO-2555).
Once the other PR is merged, this should go into the
trunkas well. Until then this won't get merged.