ECTO-2555 - Display hint when upgrading access granted IAP#136
Open
Jannik (qysp) wants to merge 1 commit intotrunkfrom
Open
ECTO-2555 - Display hint when upgrading access granted IAP#136Jannik (qysp) wants to merge 1 commit intotrunkfrom
Jannik (qysp) wants to merge 1 commit intotrunkfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds UI messaging in the administration checkout flow to warn users when an “access granted” in-app purchase upgrade will permanently remove free access, and extends the subscription-change data model to support richer downgrade/pending-downgrade data.
Changes:
- Extend
InAppPurchaseSubscriptionChangeStructto include a nullablependingDowngradestruct,isIncludedInPluginLicense, and changecurrentNetPricetofloat. - Introduce
InAppPurchasePendingDowngradeStruct(+ corresponding TS types) to represent pending downgrade details. - Add administration UI + styling + unit tests to render a new “attention” banner and show “free” when included in a plugin license.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Struct/InAppPurchaseSubscriptionChangeStruct.php | Extends subscription-change struct (pending downgrade struct, net price type, plugin-license inclusion flag). |
| src/Struct/InAppPurchasePendingDowngradeStruct.php | New struct representing pending downgrade feature + net price. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/types/index.ts | Updates admin TS types to reflect new pending downgrade shape and inclusion flag. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/snippet/en.json | Adds new translation strings for the new banner and “free” label. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/snippet/de.json | Adds German translation strings for the new banner and “free” label. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/sw-in-app-purchase-checkout-subscription-change.spec.js | Adds component unit tests for the new computed flag and banner rendering. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/sw-in-app-purchase-checkout-subscription-change.scss | Styles the new banner block. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/sw-in-app-purchase-checkout-subscription-change.html.twig | Renders “free” label conditionally and adds the attention banner. |
| src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/index.ts | Adds computed isIncludedInPluginLicense and getCurrentPlanName used by the template/banner. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
778b636 to
14d330f
Compare
Kai Gossel (kaigossel)
approved these changes
Mar 20, 2026
src/Resources/app/administration/src/module/sw-in-app-purchases/snippet/de.json
Show resolved
Hide resolved
Michel (cyl3x)
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've also noticed that some of the properties of the subscription change struct are incorrect and fixed it.