Skip to content

ECTO-2555 - Display hint when upgrading access granted IAP#136

Open
Jannik (qysp) wants to merge 1 commit intotrunkfrom
evaluation/ECTO-2555
Open

ECTO-2555 - Display hint when upgrading access granted IAP#136
Jannik (qysp) wants to merge 1 commit intotrunkfrom
evaluation/ECTO-2555

Conversation

@qysp
Copy link
Collaborator

@qysp Jannik (qysp) commented Mar 18, 2026

I've also noticed that some of the properties of the subscription change struct are incorrect and fixed it.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds UI messaging in the administration checkout flow to warn users when an “access granted” in-app purchase upgrade will permanently remove free access, and extends the subscription-change data model to support richer downgrade/pending-downgrade data.

Changes:

  • Extend InAppPurchaseSubscriptionChangeStruct to include a nullable pendingDowngrade struct, isIncludedInPluginLicense, and change currentNetPrice to float.
  • Introduce InAppPurchasePendingDowngradeStruct (+ corresponding TS types) to represent pending downgrade details.
  • Add administration UI + styling + unit tests to render a new “attention” banner and show “free” when included in a plugin license.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Struct/InAppPurchaseSubscriptionChangeStruct.php Extends subscription-change struct (pending downgrade struct, net price type, plugin-license inclusion flag).
src/Struct/InAppPurchasePendingDowngradeStruct.php New struct representing pending downgrade feature + net price.
src/Resources/app/administration/src/module/sw-in-app-purchases/types/index.ts Updates admin TS types to reflect new pending downgrade shape and inclusion flag.
src/Resources/app/administration/src/module/sw-in-app-purchases/snippet/en.json Adds new translation strings for the new banner and “free” label.
src/Resources/app/administration/src/module/sw-in-app-purchases/snippet/de.json Adds German translation strings for the new banner and “free” label.
src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/sw-in-app-purchase-checkout-subscription-change.spec.js Adds component unit tests for the new computed flag and banner rendering.
src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/sw-in-app-purchase-checkout-subscription-change.scss Styles the new banner block.
src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/sw-in-app-purchase-checkout-subscription-change.html.twig Renders “free” label conditionally and adds the attention banner.
src/Resources/app/administration/src/module/sw-in-app-purchases/component/sw-in-app-purchase-checkout-subscription-change/index.ts Adds computed isIncludedInPluginLicense and getCurrentPlanName used by the template/banner.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qysp Jannik (qysp) marked this pull request as ready for review March 18, 2026 12:34
@qysp Jannik (qysp) requested review from a team and removed request for Michel (cyl3x) March 20, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants