[SEI-9449] Remove unused invariant checks #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jewei1997
requested review from
philipsu522,
sei-will and
stevenlanders
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 54.33% 54.25% -0.08%
==========================================
Files 634 632 -2
Lines 55574 55282 -292
==========================================
- Hits 30194 29992 -202
+ Misses 23209 23143 -66
+ Partials 2171 2147 -24
🚀 New features to boost your workflow:
|
jewei1997
requested review from
codchen and
udpatil
and removed request for
udpatil
codchen
approved these changes
Aug 4, 2025
sei-will
approved these changes
Aug 4, 2025
philipsu522
reviewed
Aug 4, 2025
Comment on lines
-25
to
-38
| return func(ctx sdk.Context) (string, bool) { | ||
| res, stop := CanWithdrawInvariant(k)(ctx) | ||
| if stop { | ||
| return res, stop | ||
| } | ||
| res, stop = NonNegativeOutstandingInvariant(k)(ctx) | ||
| if stop { | ||
| return res, stop | ||
| } | ||
| res, stop = ReferenceCountInvariant(k)(ctx) | ||
| if stop { | ||
| return res, stop | ||
| } | ||
| return ModuleAccountInvariant(k)(ctx) |
Contributor
There was a problem hiding this comment.
do we somehow capture these scenarios via unit tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
These invariant checks are no longer used, so we're deprecating them.
Testing performed to validate your change
N/A