-
Notifications
You must be signed in to change notification settings - Fork 856
[SEI-9449] Remove unused invariant checks #2275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2275 +/- ##
==========================================
+ Coverage 60.24% 60.32% +0.07%
==========================================
Files 311 311
Lines 30240 30273 +33
==========================================
+ Hits 18219 18261 +42
+ Misses 10734 10723 -11
- Partials 1287 1289 +2
🚀 New features to boost your workflow:
|
|
|
||
| optimisticProcessingInfo *OptimisticProcessingInfo | ||
| optimisticProcessingInfo OptimisticProcessingInfo | ||
| optimisticProcessingInfoMutex sync.RWMutex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this mutex change intended? Do we see race conditions without it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes without it there's race conditions in this test: TestSkipOptimisticProcessingOnUpgrade
* remove invariant checks * fix test * fix race condition in test * fix lint * add coverage
Describe your changes and provide context
pulling in sei-cosmos changes for removing unused invariant checks here sei-protocol/sei-cosmos#593
Testing performed to validate your change
N/A