Skip to content

Conversation

@jewei1997
Copy link
Contributor

Describe your changes and provide context

pulling in sei-cosmos changes for removing unused invariant checks here sei-protocol/sei-cosmos#593

Testing performed to validate your change

N/A

@jewei1997 jewei1997 changed the title remove invariant checks [SEI-9449] Remove unused invariant checks Jul 31, 2025
@jewei1997 jewei1997 requested a review from codchen August 3, 2025 17:42
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.32%. Comparing base (9fe5721) to head (cf1c5fe).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/app.go 95.45% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2275      +/-   ##
==========================================
+ Coverage   60.24%   60.32%   +0.07%     
==========================================
  Files         311      311              
  Lines       30240    30273      +33     
==========================================
+ Hits        18219    18261      +42     
+ Misses      10734    10723      -11     
- Partials     1287     1289       +2     
Files with missing lines Coverage Δ
app/upgrades.go 29.41% <100.00%> (ø)
app/app.go 67.04% <95.45%> (+1.56%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


optimisticProcessingInfo *OptimisticProcessingInfo
optimisticProcessingInfo OptimisticProcessingInfo
optimisticProcessingInfoMutex sync.RWMutex
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this mutex change intended? Do we see race conditions without it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes without it there's race conditions in this test: TestSkipOptimisticProcessingOnUpgrade

@jewei1997 jewei1997 enabled auto-merge (squash) August 8, 2025 14:31
@jewei1997 jewei1997 merged commit be53281 into main Aug 10, 2025
60 of 63 checks passed
@jewei1997 jewei1997 deleted the sei-9449/remove-invariant-checks branch August 10, 2025 21:55
jewei1997 added a commit that referenced this pull request Aug 11, 2025
* remove invariant checks

* fix test

* fix race condition in test

* fix lint

* add coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants