Skip to content

Remove redundant skip decorators for broadcast_rpc_port tests #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkropachev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove redundant skip decorators for broadcast_rpc_port tests #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/integration/standard/test_control_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@ def test_get_control_connection_host(self):

assert new_host1 != new_host2

# TODO: enable after https://github.com/scylladb/python-driver/issues/121 is fixed
@unittest.skip('Fails on scylla due to the broadcast_rpc_port is None')
@greaterthanorequalcass40
def test_control_connection_port_discovery(self):
"""
Expand Down
8 changes: 4 additions & 4 deletions tests/integration/standard/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ def setup_module():


class HostMetaDataTests(BasicExistingKeyspaceUnitTestCase):
# TODO: enable after https://github.com/scylladb/python-driver/issues/121 is fixed
@unittest.skip('Fails on scylla due to the broadcast_rpc_port is None')
@local
def test_host_addresses(self):
"""
Expand All @@ -85,8 +83,10 @@ def test_host_addresses(self):
local_host = con.host

# The control connection node should have the listen address set.
listen_addrs = [host.listen_address for host in self.cluster.metadata.all_hosts()]
assert local_host in listen_addrs
# Note: Scylla does not populate listen_address in system.local
if SCYLLA_VERSION is None:
listen_addrs = [host.listen_address for host in self.cluster.metadata.all_hosts()]
assert local_host in listen_addrs

# The control connection node should have the broadcast_rpc_address set.
rpc_addrs = [host.broadcast_rpc_address for host in self.cluster.metadata.all_hosts()]
Expand Down
2 changes: 0 additions & 2 deletions tests/integration/standard/test_single_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ def tearDown(self):
if self.cluster is not None:
self.cluster.shutdown()

# TODO: enable after https://github.com/scylladb/python-driver/issues/121 is fixed
@unittest.skip('Fails on scylla due to the broadcast_rpc_port is None')
def test_single_interface(self):
"""
Test that we can connect to a multiple hosts bound to a single interface.
Expand Down
Loading