Remove redundant skip decorators for broadcast_rpc_port tests #671
+4
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@unittest.skipdecorators that reference issue Host metadata broadcast_rpc_port is None #121listen_addresscheck for Scylla (Scylla doesn't populate this field insystem.local)The skip decorators were redundant because:
@greaterthanorequalcass40which skips for Scylla (mapped to Cassandra 3.11.4)SingleInterfaceTestclass has@greaterthanorequalcass40CASSANDRA_VERSION >= Version('4-a')Since Scylla's
CASSANDRA_VERSIONdefaults to3.11.4(viaMAPPED_SCYLLA_VERSION), these version checks already prevent the port-related assertions from running on Scylla clusters.Additionally, the
listen_addressassertion intest_host_addressesis now skipped for Scylla since Scylla doesn't populate this field in itssystem.localtable.Test plan
Fixes #121