Skip to content

packaging: harden smoke-test cluster startup #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkropachev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

packaging: harden smoke-test cluster startup #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions packaging/smoke-test-app/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,7 @@ test-app-package: .prepare-for-test
"$$smoke_bin" $(SCYLLA_HOST);\
else\
dc="";\
compose_file="${MAKEFILE_PATH}/docker-compose.yml";\
if docker compose version >/dev/null 2>&1; then\
dc="docker compose";\
elif command -v docker-compose >/dev/null 2>&1; then\
Expand All @@ -420,11 +421,36 @@ test-app-package: .prepare-for-test
fi;\
cleanup() {\
if [ -n "$$dc" ]; then\
sudo $$dc -f ${MAKEFILE_PATH}/docker-compose.yml down --remove-orphans;\
sudo $$dc -f "$$compose_file" down --remove-orphans >/dev/null 2>&1 || true;\
fi;\
};\
start_cluster() {\
for attempt in 1 2 3; do\
cid="";\
status="";\
if ! sudo $$dc -f "$$compose_file" up -d; then\
echo "docker compose up failed on attempt $$attempt";\
fi;\
cid="$$(sudo $$dc -f "$$compose_file" ps -q scylla 2>/dev/null || true)";\
if [ -n "$$cid" ]; then\
for _ in $$(seq 1 60); do\
status="$$(sudo docker inspect --format '{{if .State.Health}}{{.State.Health.Status}}{{else}}{{.State.Status}}{{end}}' "$$cid" 2>/dev/null || true)";\
if [ "$$status" = "healthy" ]; then\
return 0;\
fi;\
sleep 2;\
done;\
fi;\
echo "Cluster did not become healthy on attempt $$attempt";\
sudo $$dc -f "$$compose_file" ps || true;\
sudo $$dc -f "$$compose_file" logs --tail=200 scylla || true;\
cleanup;\
sleep 5;\
done;\
return 1;\
};\
trap cleanup EXIT;\
sudo $$dc -f ${MAKEFILE_PATH}/docker-compose.yml up -d --wait;\
start_cluster;\
"$$smoke_bin" $(SCYLLA_HOST);\
fi
endif
Loading