packaging: harden smoke-test cluster startup#458
Open
dkropachev wants to merge 1 commit into
Open
Conversation
Harden the non-Windows smoke-test path that starts the Scylla package-test cluster. Keep the existing docker-compose-based flow, but stop assuming that `docker compose up --wait` is enough to guarantee that the cluster is actually ready for the smoke binary. Reuse a dedicated compose-file variable, make teardown non-fatal, retry startup a few times, and inspect the Scylla container health before running the smoke app. When startup still fails, dump compose state and recent Scylla logs so CI failures are diagnosable from the job output.
dkropachev
force-pushed
the
packaging/harden-smoke-test-cluster-startup
branch
from
f45e748 to
e23f18f
Compare
wprzytula
requested changes
May 22, 2026
Contributor
wprzytula
left a comment
wprzytula
left a comment
There was a problem hiding this comment.
I doubt this is needed at all. See docker/compose#8777 (comment). If a healthcheck condition is defined (which is the case in our docker-compose.yml), docker compose up --wait waits until the service is healthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker compose up, wait for the Scylla container to become healthy, and dump compose state/logs when startup failsTesting
make test-package-linuxand by the succeeding macOS package CI job after the hardening was introducedChecklist
Makefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.Fixes:annotations to PR description.