use std::move() for local variables that are copied but not reused#7308
Open
Goober5000 wants to merge 3 commits intoscp-fs2open:masterfrom
Open
use std::move() for local variables that are copied but not reused#7308Goober5000 wants to merge 3 commits intoscp-fs2open:masterfrom
Goober5000 wants to merge 3 commits intoscp-fs2open:masterfrom
Conversation
Addresses ~140 Coverity "Variable copied when it could be moved" defects across 74 files. Every std::move() targets a local variable whose value is consumed by push_back, emplace, assignment, lambda capture, or a function call and is never read again afterward. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Goober5000
force-pushed
the
coverity/copy-to-move
branch
from
025756b to
8bfdb2e
Compare
Goober5000
force-pushed
the
coverity/copy-to-move
branch
from
8bfdb2e to
29704fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses ~140 Coverity "Variable copied when it could be moved" defects across 74 files. Every std::move() targets a local variable whose value is consumed by push_back, emplace, assignment, lambda capture, or a function call and is never read again afterward.
Also use
std::make_sharedandstd::make_unique, per clang.