Add DisposableAnalyzer foreach tests and fix enumerator false positives#258
Add DisposableAnalyzer foreach tests and fix enumerator false positives#258google-labs-jules[bot] wants to merge 3 commits into
Conversation
… for enumerators. - Added unit tests for foreach loops with IEnumerable, List<T>, and arrays in DisposableAnalyzerUnitTests.cs. - Modified DisposableAnalyzer to ignore types ending with "Enumerator" to prevent false positives when enumerators are used in foreach blocks or returned from methods.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: sator-imaging <16752340+sator-imaging@users.noreply.github.com>
Co-authored-by: sator-imaging <16752340+sator-imaging@users.noreply.github.com>
This change addresses the need for verifying that
DisposableAnalyzerdoes not report false positives whenforeachloops are used. In C#, the compiler automatically handles the disposal of enumerators inforeachblocks. The analyzer now ignores any type whose name ends with "Enumerator", which coversIEnumerator,IEnumerator<T>, and concrete enumerator implementations.Added tests cover:
IEnumerableimplementation.foreachon a method returningIEnumerable.foreachonList<float>.foreachonstring[].All tests passed successfully.
PR created automatically by Jules for task 3140017500505977013 started by @sator-imaging