Skip to content

Add DisposableAnalyzer foreach tests and fix enumerator false positives#258

Open
google-labs-jules[bot] wants to merge 3 commits into
mainfrom
disposable-analyzer-foreach-tests-3140017500505977013
Open

Add DisposableAnalyzer foreach tests and fix enumerator false positives#258
google-labs-jules[bot] wants to merge 3 commits into
mainfrom
disposable-analyzer-foreach-tests-3140017500505977013

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

This change addresses the need for verifying that DisposableAnalyzer does not report false positives when foreach loops are used. In C#, the compiler automatically handles the disposal of enumerators in foreach blocks. The analyzer now ignores any type whose name ends with "Enumerator", which covers IEnumerator, IEnumerator<T>, and concrete enumerator implementations.

Added tests cover:

  • Custom IEnumerable implementation.
  • foreach on a method returning IEnumerable.
  • foreach on List<float>.
  • foreach on string[].

All tests passed successfully.


PR created automatically by Jules for task 3140017500505977013 started by @sator-imaging

… for enumerators.

- Added unit tests for foreach loops with IEnumerable, List<T>, and arrays in DisposableAnalyzerUnitTests.cs.
- Modified DisposableAnalyzer to ignore types ending with "Enumerator" to prevent false positives when enumerators are used in foreach blocks or returned from methods.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Comment thread src/StaticMemberAnalyzer.Analysis/Analyzers/DisposableAnalyzer.cs Outdated
Co-authored-by: sator-imaging <16752340+sator-imaging@users.noreply.github.com>
Comment thread src/StaticMemberAnalyzer.Analysis/Analyzers/DisposableAnalyzer.cs
Co-authored-by: sator-imaging <16752340+sator-imaging@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant