Skip to content

Cleanup of comment, as it is no longer accurate #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
L0r3nz-H wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −9
Draft

Cleanup of comment, as it is no longer accurate #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions plugin/impl/eviction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,6 @@ func (e *Eviction) Trigger(params plugin.Parameters) error {
params.Node.Spec.Unschedulable = false
return nil
case Drain:
// original comment:
// The implementation below is technically wrong.
// Just assigning true to Unschedulable does not patch the node object on the api server.
// This done at the end of the reconciliation loop.
// Actively patching within this plugin increases the resource version to increase.
// The increment causes the patch at then end of the reconciliation loop to fail,
// which consistently drops state.
// Assigning true to unschedulable here is a sanity action.
// The user should configure to run the cordon action before running the drain action.
params.Node.Spec.Unschedulable = true
drained, err := common.EnsureDrain(params.Ctx, params.Node, params.Log, common.DrainParameters{
AwaitDeletion: common.WaitParameters{
Expand Down
Loading