Skip to content

Cleanup of comment, as it is no longer accurate#380

Draft
L0r3nz-H wants to merge 1 commit intomasterfrom
cleanup-comment
Draft

Cleanup of comment, as it is no longer accurate#380
L0r3nz-H wants to merge 1 commit intomasterfrom
cleanup-comment

Conversation

@L0r3nz-H
Copy link
Copy Markdown
Contributor

@L0r3nz-H L0r3nz-H commented Mar 27, 2026

I wanted to delete a comment here. It may be confusing, as it describes a technically wrong implementation, which was corrected in #353.

@L0r3nz-H L0r3nz-H changed the title Cleanup of original comment, as it is no longer accurate Cleanup of comment, as it is no longer accurate Mar 27, 2026
@github-actions
Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/maintenance-controller/plugin/impl 81.14% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/maintenance-controller/plugin/impl/eviction.go 76.19% (ø) 21 16 5

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@L0r3nz-H L0r3nz-H marked this pull request as ready for review March 27, 2026 14:30
@L0r3nz-H L0r3nz-H marked this pull request as draft March 27, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant