Skip to content

fix(http): enable DNS-rebinding protection by default #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SVilgelm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(http): enable DNS-rebinding protection by default #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions crates/rust-mcp-sdk/src/hyper_servers/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ pub struct HyperServerOptions {
pub allowed_origins: Option<Vec<String>>,

/// Enable DNS rebinding protection (requires allowedHosts and/or allowedOrigins to be configured).
/// Default is false for backwards compatibility.
/// Default is `true`; a startup warning is logged if neither `allowed_hosts`
/// nor `allowed_origins` is set. Set to `false` to opt out.
pub dns_rebinding_protection: bool,

/// If set to true, the SSE transport will also be supported for backward compatibility (default: true)
Expand Down Expand Up @@ -282,7 +283,7 @@ impl Default for HyperServerOptions {
sse_support: true,
allowed_hosts: None,
allowed_origins: None,
dns_rebinding_protection: false,
dns_rebinding_protection: true,
event_store: None,
#[cfg(feature = "auth")]
auth: None,
Expand Down Expand Up @@ -340,6 +341,17 @@ impl HyperServer {

// populate middlewares
let mut middlewares: Vec<Arc<dyn Middleware>> = vec![];
if server_options.dns_rebinding_protection
&& server_options.allowed_hosts.is_none()
&& server_options.allowed_origins.is_none()
{
tracing::warn!(
"DNS-rebinding protection is enabled but neither `allowed_hosts` nor \
`allowed_origins` is configured, so Host/Origin validation is not enforced. \
Set `allowed_hosts`/`allowed_origins`, or set `dns_rebinding_protection = false` \
to silence this warning."
);
}
if server_options.needs_dns_protection() {
//dns pritection middleware
middlewares.push(Arc::new(DnsRebindProtector::new(
Expand Down
Loading